Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23141 )
Change subject: IMPALA-14018: Adding utility scripts to run Lakekeeper in Impala dev envinroment ...................................................................... Patch Set 2: (5 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/23141/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23141/1//COMMIT_MSG@18 PS1, Line 18: Usage > Could you create a README file with these instructions in testdata/bin/mini Done http://gerrit.cloudera.org:8080/#/c/23141/1//COMMIT_MSG@27 PS1, Line 27: TODO > Do you plan to resolve it in this patch? Probably I'll do it in a follow-up patch/Jira. I don't plan to mix the two, they will live separately, but Trino should also use docker compose as the start/stop will be nicer (currently you need to issue docker stop then docker rm...). http://gerrit.cloudera.org:8080/#/c/23141/1//COMMIT_MSG@39 PS1, Line 39: use iceberg_lakekeeper.trino_db; > Shouldn't it be Done, added USE statement. http://gerrit.cloudera.org:8080/#/c/23141/1/testdata/bin/run-lakekeeper.sh File testdata/bin/run-lakekeeper.sh: http://gerrit.cloudera.org:8080/#/c/23141/1/testdata/bin/run-lakekeeper.sh@27 PS1, Line 27: docker compose > Should be docker-compose. docker-compose (Compose V1) is deprecated, and there will be no updates for it. Users should move to docker compose (Compose V2). http://gerrit.cloudera.org:8080/#/c/23141/1/testdata/bin/stop-lakekeeper.sh File testdata/bin/stop-lakekeeper.sh: http://gerrit.cloudera.org:8080/#/c/23141/1/testdata/bin/stop-lakekeeper.sh@22 PS1, Line 22: docker compose > Should be docker-compose. Same as in run-lakekeeper.sh -- To view, visit http://gerrit.cloudera.org:8080/23141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I610f5859f92b2ff82e310f46356e3f118e986b2c Gerrit-Change-Number: 23141 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 08 Jul 2025 12:12:15 +0000 Gerrit-HasComments: Yes
