Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23097 )
Change subject: IMPALA-13235: [Patch 2 of 5] - Add OpenSSL Utility Function to Validate PEM Bundles ...................................................................... Patch Set 11: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23097/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23097/11//COMMIT_MSG@12 PS11, Line 12: them nit: the http://gerrit.cloudera.org:8080/#/c/23097/9/be/src/util/openssl-util-test.cc File be/src/util/openssl-util-test.cc: http://gerrit.cloudera.org:8080/#/c/23097/9/be/src/util/openssl-util-test.cc@353 PS9, Line 353: : // Expired cert is last in the bundle. : ASSERT_ERROR_MSG(ValidatePemBundle(Substitute("$0$1$2", read_cert(VALID_CERT_1), : read_cert(VALID_CERT_2), read_cert(FUTURE_CERT))), _msg_time(1, 0)); : } : : /// Asserts a bundle is invalid if it contains two expired and one non-expired : /// certificate no matter the position of the expired cert in the bundle. : TEST_F(OpenSSLUtilTest, ValidatePemBundleThreeCertsTwoExpired) { > good catch, fixed the "Invalid cert is in the middle of the bundle" so the Done -- To view, visit http://gerrit.cloudera.org:8080/23097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e9f12e854b679ccf3e94a38c2688a7431460a7a Gerrit-Change-Number: 23097 Gerrit-PatchSet: 11 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Tue, 08 Jul 2025 20:42:52 +0000 Gerrit-HasComments: Yes
