Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10616 )
Change subject: Guard S3 access check with variable ...................................................................... Guard S3 access check with variable We've recently seen automated build failures where multiple inclusions of impala-config.sh led to the S3 access check being performed multiple times. This would trigger rate limiting on S3's side, which then caused the jobs to fail. This change adds a guard to only perform the check once, even when including impala-config.sh multiple times. To test this I included impala-config.sh multiple times on my local shell and observed that the check was only performed once. Change-Id: I1df16b2d037afafb7748f52b64732f680883f16c Reviewed-on: http://gerrit.cloudera.org:8080/10607 Reviewed-by: Lars Volker <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-on: http://gerrit.cloudera.org:8080/10616 Tested-by: Tim Armstrong <[email protected]> --- M bin/impala-config.sh 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Lars Volker: Looks good to me, approved Tim Armstrong: Verified -- To view, visit http://gerrit.cloudera.org:8080/10616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: merged Gerrit-Change-Id: I1df16b2d037afafb7748f52b64732f680883f16c Gerrit-Change-Number: 10616 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
