Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries in frontend ...................................................................... Patch Set 53: (6 comments) http://gerrit.cloudera.org:8080/#/c/21803/51/fe/src/main/java/org/apache/impala/service/Canceller.java File fe/src/main/java/org/apache/impala/service/Canceller.java: http://gerrit.cloudera.org:8080/#/c/21803/51/fe/src/main/java/org/apache/impala/service/Canceller.java@45 PS51, Line 45: > nit: this can be final Ack http://gerrit.cloudera.org:8080/#/c/21803/51/fe/src/main/java/org/apache/impala/service/Canceller.java@50 PS51, Line 50: // Registers that the current thread has been cancelled and should clean up. > nit: this can be final Done http://gerrit.cloudera.org:8080/#/c/21803/51/fe/src/main/java/org/apache/impala/service/Canceller.java@54 PS51, Line 54: > nit: method comments start with '/**' Done http://gerrit.cloudera.org:8080/#/c/21803/51/fe/src/main/java/org/apache/impala/service/Canceller.java@106 PS51, Line 106: > nit: these can also be final Done http://gerrit.cloudera.org:8080/#/c/21803/51/fe/src/main/java/org/apache/impala/service/Canceller.java@127 PS51, Line 127: : : > Yes, the current thread would check the thread local, while other threads c I've switched to using the AtomicBoolean. That simplified concurrency handling, so I've returned to using a single ConcurrentHashMap. Race condition checks are no longer needed, so the finer granularity of ConcurrentHashMap seems like a good default with no additional complexity. http://gerrit.cloudera.org:8080/#/c/21803/51/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/21803/51/tests/webserver/test_web_pages.py@1116 PS51, Line 1116: =canc > typo Done -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 53 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 08 Jul 2025 23:45:38 +0000 Gerrit-HasComments: Yes
