Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23068 )
Change subject: IMPALA-13474: Support aggregated profile for webUI's query timeline ...................................................................... Patch Set 5: (12 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/fragment_diagram.js File www/scripts/query_timeline/fragment_diagram.js: http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/fragment_diagram.js@419 PS5, Line 419: if (profile_format == 1) { Expected '===' and instead saw '=='. http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/fragment_diagram.js@466 PS5, Line 466: if (profile_format == 1 || execution_profile.child_profiles[2].event_sequences Expected '===' and instead saw '=='. http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/fragment_diagram.js@597 PS5, Line 597: export function setTimingDiagramDimensions(ignored_arg) { 'ignored_arg' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/fragment_diagram.js@628 PS5, Line 628: if (profile_format == 1) { Expected '===' and instead saw '=='. http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/fragment_diagram.js@637 PS5, Line 637: fragment_diagram.addEventListener("mouseout", e => { 'e' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/fragment_metrics_diagram.js File www/scripts/query_timeline/fragment_metrics_diagram.js: http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/fragment_metrics_diagram.js@99 PS5, Line 99: value : (value, ratio, id, index) => { 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/fragment_metrics_diagram.js@106 PS5, Line 106: title : (x, index) => x.toFixed(decimals) 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/fragment_metrics_diagram.js@297 PS5, Line 297: function dragResizeBarBegin(mousedown_e) { 'mousedown_e' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/host_utilization_diagram.js File www/scripts/query_timeline/host_utilization_diagram.js: http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/host_utilization_diagram.js@122 PS5, Line 122: value : (value, ratio, id, index) => { 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/host_utilization_diagram.js@129 PS5, Line 129: title : (x, index) => x.toFixed(decimals) + "s" 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/host_utilization_diagram.js@315 PS5, Line 315: function dragResizeBarBegin(mousedown_e) { 'mousedown_e' is defined but never used. http://gerrit.cloudera.org:8080/#/c/23068/5/www/scripts/query_timeline/host_utilization_diagram.js@325 PS5, Line 325: host_utilization_close_btn.addEventListener("click", e => { 'e' is defined but never used. -- To view, visit http://gerrit.cloudera.org:8080/23068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1f59bc8ab6bee91bd5fa446a207891453600b3e Gerrit-Change-Number: 23068 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 10 Jul 2025 09:00:06 +0000 Gerrit-HasComments: Yes
