Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23097 )
Change subject: IMPALA-13235: [Patch 2 of 5] - Add OpenSSL Utility Function to Validate PEM Bundles ...................................................................... Patch Set 14: Code-Review+1 (1 comment) LGTM! http://gerrit.cloudera.org:8080/#/c/23097/9/be/src/util/openssl-util-test.cc File be/src/util/openssl-util-test.cc: http://gerrit.cloudera.org:8080/#/c/23097/9/be/src/util/openssl-util-test.cc@272 PS9, Line 272: / Cons > I would have preferred using the ASSERT_ macros, but they cannot be used si There is also CHECK, but if it's quite intended to behave as-is with EXPECT, that's totally fine, I guess. -- To view, visit http://gerrit.cloudera.org:8080/23097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e9f12e854b679ccf3e94a38c2688a7431460a7a Gerrit-Change-Number: 23097 Gerrit-PatchSet: 14 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 10 Jul 2025 19:28:15 +0000 Gerrit-HasComments: Yes
