Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23156 )
Change subject: IMPALA-14018: Configure OAUTH2 with Lakekeeper and fix Impala's config handling ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/23156/2/fe/src/main/java/org/apache/impala/catalog/iceberg/RESTCatalogProperties.java File fe/src/main/java/org/apache/impala/catalog/iceberg/RESTCatalogProperties.java: http://gerrit.cloudera.org:8080/#/c/23156/2/fe/src/main/java/org/apache/impala/catalog/iceberg/RESTCatalogProperties.java@254 PS2, Line 254: Preconditions.checkState(!finalMap_.containsKey(entry.getKey())); We could assert that the return value of finalMap_.put() is NULL instead. http://gerrit.cloudera.org:8080/#/c/23156/2/fe/src/test/java/org/apache/impala/catalog/iceberg/TestRESTCatalogProperties.java File fe/src/test/java/org/apache/impala/catalog/iceberg/TestRESTCatalogProperties.java: http://gerrit.cloudera.org:8080/#/c/23156/2/fe/src/test/java/org/apache/impala/catalog/iceberg/TestRESTCatalogProperties.java@40 PS2, Line 40: assertTrue(true); This assertion is redundant. Also applies to other tests. http://gerrit.cloudera.org:8080/#/c/23156/2/fe/src/test/java/org/apache/impala/catalog/iceberg/TestRESTCatalogProperties.java@116 PS2, Line 116: if required properties are not defined Here the problem is that properties are defined with two alternative names. http://gerrit.cloudera.org:8080/#/c/23156/2/fe/src/test/java/org/apache/impala/catalog/iceberg/TestRESTCatalogProperties.java@148 PS2, Line 148: if required properties are not defined Here the problem is that a config has an incorrect value. http://gerrit.cloudera.org:8080/#/c/23156/2/fe/src/test/java/org/apache/impala/catalog/iceberg/TestRESTCatalogProperties.java@166 PS2, Line 166: iceberg.catalog.type This is the ignored value, right? We could check that it is not present in restProps. -- To view, visit http://gerrit.cloudera.org:8080/23156 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5785cb72773e188b1de7c7924cc6f0b1f96de33 Gerrit-Change-Number: 23156 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Fri, 11 Jul 2025 13:36:38 +0000 Gerrit-HasComments: Yes
