Jason Fehr has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23161 )

Change subject: IMPALA-14217: Fixes Incompatibility with OpenSSL 1.0
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23161/3/be/src/util/openssl-util-test.cc
File be/src/util/openssl-util-test.cc:

http://gerrit.cloudera.org:8080/#/c/23161/3/be/src/util/openssl-util-test.cc@285
PS3, Line 285:   CHECK(!contents.ToString().empty()) << "Certificate '" << 
cert_name
Switching from EXPECT_TRUE/FALSE to CHECK causes the test to fail immediately.  
For more information, see the comment thread at 
https://gerrit.cloudera.org/c/23097/9/be/src/util/openssl-util-test.cc#272



--
To view, visit http://gerrit.cloudera.org:8080/23161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If58a12f14a5509d62b7cfe291372b53b440da511
Gerrit-Change-Number: 23161
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Jul 2025 18:02:03 +0000
Gerrit-HasComments: Yes

Reply via email to