Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23155 )

Change subject: IMPALA-14074: Warmup metadata cache in catalogd for critical 
tables
......................................................................


Patch Set 6: Code-Review+2

(2 comments)

LGTM, Thanks!

http://gerrit.cloudera.org:8080/#/c/23155/5/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:

http://gerrit.cloudera.org:8080/#/c/23155/5/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@1288
PS5, Line 1288:
> Good point! We can lowercase these to avoid users making mistakes in the co
Done


http://gerrit.cloudera.org:8080/#/c/23155/5/testdata/data/warmup_table_list.txt
File testdata/data/warmup_table_list.txt:

http://gerrit.cloudera.org:8080/#/c/23155/5/testdata/data/warmup_table_list.txt@12
PS5, Line 12: tpcds.Item
> Nevermind, these add good coverage!
Done



--
To view, visit http://gerrit.cloudera.org:8080/23155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d09eae1f12a8acd2de945984d956d11eeee1ab6
Gerrit-Change-Number: 23155
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 12 Jul 2025 01:11:37 +0000
Gerrit-HasComments: Yes

Reply via email to