Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/22716 )
Change subject: IMPALA-13011: [WIP] Support authorization for Calcite in Impala ...................................................................... Patch Set 8: (2 comments) > Patch Set 6: > > (1 comment) > > gerrit-auto-critic failed. You can reproduce it locally using command: > > python3 bin/jenkins/critique-gerrit-review.py --dryrun > > To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22716/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaPrivilegeRequestsRegistrar.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaPrivilegeRequestsRegistrar.java: http://gerrit.cloudera.org:8080/#/c/22716/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaPrivilegeRequestsRegistrar.java@155 PS5, Line 155: // We do not process a CalciteContextException caught since it should have > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/22716/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaPrivilegeRequestsRegistrar.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaPrivilegeRequestsRegistrar.java: http://gerrit.cloudera.org:8080/#/c/22716/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaPrivilegeRequestsRegistrar.java@155 PS6, Line 155: // We do not process a CalciteContextException caught since it should have > line too long (92 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/22716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a7f7e4dc9a86a2da9e387832e552538e34029c1 Gerrit-Change-Number: 22716 Gerrit-PatchSet: 8 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 14 Jul 2025 16:13:46 +0000 Gerrit-HasComments: Yes
