Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23173 )
Change subject: IMPALA-14221: Avoid hard-coding table list in TestWarmupCatalog ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23173/1/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/23173/1/tests/custom_cluster/test_restart_services.py@1180 PS1, Line 1180: for i in range(1, 1 + num_tpch_tables): : assert "tpch." in logs[i] : assert "tpcds.customer" in logs[num_tpch_tables + 1] : assert "tpcds.date_dim" in logs[num_tpch_tables + 2] : assert "tpcds.item" in logs[num_tpch_tables + 3] : assert "functional.#" in logs[num_tpch_tables + 4] : assert "functional.alltypes etc #" in logs[num_tpch_tables + 5] I'm worried if this enumeration will become flaky in the future. What if you simply join logs into single string and assert over that single string instead? -- To view, visit http://gerrit.cloudera.org:8080/23173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0aca8ee19146f2e63e7cd82177d9fce0b8c6736a Gerrit-Change-Number: 23173 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 15 Jul 2025 04:04:26 +0000 Gerrit-HasComments: Yes
