Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23074 )
Change subject: IMPALA-13898: Incorporate partition information into tuple cache keys ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/23074/10/tests/query_test/test_scanners_fuzz.py File tests/query_test/test_scanners_fuzz.py: http://gerrit.cloudera.org:8080/#/c/23074/10/tests/query_test/test_scanners_fuzz.py@114 PS10, Line 114: pytest.xfail("IMPALA-14219: this test can crash Impala") > Isn't crashing impalad a thing we'd want to avoid? These are not custom clu This a quirk of pytest. The marker @pytest.mark.xfail by default runs the test and ignores failure. However, this direct call to pytest.xfail() bails out and doesn't run the test. So, it is skipping the test and won't crash impalad. I could change this to a pytest.skip() if you think that would be clearer. -- To view, visit http://gerrit.cloudera.org:8080/23074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a7109fcf8a30bf915bb566f7d642f8037793a8c Gerrit-Change-Number: 23074 Gerrit-PatchSet: 10 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 15 Jul 2025 20:52:53 +0000 Gerrit-HasComments: Yes
