Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23174 )
Change subject: IMPALA-14227: In HA failover, passive catalogd should apply pending HMS events before being active ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23174/4/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/23174/4/be/src/catalog/catalog-server.cc@890 PS4, Line 890: Status status = catalog_->GetEventProcessorSummary(req, &response); Some extra logging would be nice to indicate what is happening in the catalog,e.g. "Getting latest HMS event event id and waiting for event processor to sync up" http://gerrit.cloudera.org:8080/#/c/23174/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/23174/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1430 PS4, Line 1430: LOG.warn("Failed to fetch the latest HMS event id. Using the cached value {}", : progressInfo.latest_event_id, e); Shouldn't we return an error in this case and do metadata reset? -- To view, visit http://gerrit.cloudera.org:8080/23174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4fcb0e27c14197f79625749949b47c033a5f31 Gerrit-Change-Number: 23174 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 16 Jul 2025 11:13:38 +0000 Gerrit-HasComments: Yes
