Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23163 )
Change subject: WIP: do not review (experiment 2) ...................................................................... Patch Set 9: (40 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23163/9/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java File fe/src/main/java/org/apache/impala/planner/PlanRootSink.java: http://gerrit.cloudera.org:8080/#/c/23163/9/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@50 PS9, Line 50: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23163/9/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@217 PS9, Line 217: // in any way, we need to set the query options to the line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23163/9/fe/src/main/java/org/apache/impala/planner/ResourceProfile.java File fe/src/main/java/org/apache/impala/planner/ResourceProfile.java: http://gerrit.cloudera.org:8080/#/c/23163/9/fe/src/main/java/org/apache/impala/planner/ResourceProfile.java@34 PS9, Line 34: protected static final Logger LOG = LoggerFactory.getLogger(ResourceProfile.class.getName()); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@659 PS9, Line 659: // if both precisions are not -1, they are both varchars line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@232 PS9, Line 232: RelDataType retType = ImpalaTypeConverter.createRelDataType(factory, impalaReturnType); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@229 PS9, Line 229: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/DummyAnalyzer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/DummyAnalyzer.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/DummyAnalyzer.java@118 PS9, Line 118: public List<? extends FeDataSource> getDataSources(PatternMatcher createHivePatternMatcher) { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/DummyAnalyzer.java@144 PS9, Line 144: public TGetPartitionStatsResponse getPartitionStats(TableName table) throws InternalException { line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinProjectTransposeRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinProjectTransposeRule.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinProjectTransposeRule.java@72 PS9, Line 72: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaJoinProjectTransposeRule.class.getName()); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinPushTransitivePredicatesRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinPushTransitivePredicatesRule.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinPushTransitivePredicatesRule.java@28 PS9, Line 28: public class ImpalaJoinPushTransitivePredicatesRule extends JoinPushTransitivePredicatesRule { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@193 PS9, Line 193: private static void findRemovableOuterJoins(RelMetadataQuery mq, LoptMultiJoin multiJoin) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@350 PS9, Line 350: private static void findRemovableSelfJoins(RelMetadataQuery mq, LoptMultiJoin multiJoin) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2013 PS9, Line 2013: boolean leftSideIsGreater = (leftRowCount * leftRowSize >= rightRowCount * rightRowSize); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2014 PS9, Line 2014: RelNode greaterSideNode = leftSideIsGreater ? left.getJoinTree() : right.getJoinTree(); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2015 PS9, Line 2015: RelNode lesserSideNode = leftSideIsGreater ? right.getJoinTree() : left.getJoinTree(); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2016 PS9, Line 2016: boolean runtimeFilterCouldHelp = couldRuntimeFilterHelp(mq, lesserSideNode, greaterSideNode); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2017 PS9, Line 2017: // Swap will be true if the left side is greater, but the runtime filter will help the line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2018 PS9, Line 2018: // right side. Also, swap will be true if right side is greater, but the runtime filter line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2031 PS9, Line 2031: private static boolean couldRuntimeFilterHelp(RelMetadataQuery mq, RelNode lesserSideNode, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ReduceExprShuttle.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ReduceExprShuttle.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ReduceExprShuttle.java@118 PS9, Line 118: ReduceRexNodeShuttle shuttle = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java@47 PS9, Line 47: protected static final Logger LOG = LoggerFactory.getLogger(FilterSelectivityEstimator.class); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java@156 PS9, Line 156: * Note that = is considered a generic function and uses this method to find its selectivity. line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java@44 PS9, Line 44: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaRelMdDistinctRowCount.class.getName()); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java@47 PS9, Line 47: .reflectiveSource(BuiltInMethod.DISTINCT_ROW_COUNT.method, new ImpalaRelMdDistinctRowCount()); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java@70 PS9, Line 70: public Double getDistinctRowCount(Aggregate rel, RelMetadataQuery mq, ImmutableBitSet groupKey, line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java@82 PS9, Line 82: public Double getDistinctRowCount(Filter rel, RelMetadataQuery mq, ImmutableBitSet groupKey, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java@102 PS9, Line 102: public Double getDistinctRowCount(Join rel, RelMetadataQuery mq, ImmutableBitSet groupKey, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java@49 PS9, Line 49: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaRelMdRowCount.class.getName()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSelectivity.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSelectivity.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSelectivity.java@45 PS9, Line 45: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaRelMdSelectivity.class.getName()); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSize.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSize.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSize.java@61 PS9, Line 61: avgSize = averageTypeValueSize(table.getRowType().getFieldList().get(i).getType()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java@50 PS9, Line 50: protected static final Logger LOG = LoggerFactory.getLogger(JoinRelationInfo.class.getName()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java@100 PS9, Line 100: if (join_.getJoinType() == JoinRelType.LEFT || join_.getJoinType() == JoinRelType.FULL) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java@104 PS9, Line 104: if (join_.getJoinType() == JoinRelType.RIGHT || join_.getJoinType() == JoinRelType.FULL) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java@147 PS9, Line 147: ImmutableBitSet leftCols = RelOptUtil.InputFinder.bits(((RexCall) joinCond).getOperands().get(0)); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java@148 PS9, Line 148: ImmutableBitSet rightCols = RelOptUtil.InputFinder.bits(((RexCall) joinCond).getOperands().get(1)); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java File java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java: http://gerrit.cloudera.org:8080/#/c/23163/9/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java@72 PS9, Line 72: protected static final Logger LOG = LoggerFactory.getLogger(TestCalciteStats.class.getName()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23163/9/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/23163/9/tests/common/test_result_verifier.py@266 PS9, Line 266: def verify_query_result_is_subset_regex(expected_results, actual_results): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/23163/9/tests/common/test_result_verifier.py@270 PS9, Line 270: e flake8: F841 local variable 'expected_literal_strings' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/23163/9/tests/common/test_result_verifier.py@271 PS9, Line 271: a flake8: F841 local variable 'actual_literal_strings' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/23163/9/tests/common/test_result_verifier.py@353 PS9, Line 353: flake8: E203 whitespace before ':' -- To view, visit http://gerrit.cloudera.org:8080/23163 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fde0a7cba2181f9d3e0fe5c5a99723fbc21af91 Gerrit-Change-Number: 23163 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 16 Jul 2025 13:29:32 +0000 Gerrit-HasComments: Yes
