Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23194 )
Change subject: IMPALA-14220 (part 2): Delay AcceptRequest until catalog is stable ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/23194/4/be/src/catalog/catalog-server.h File be/src/catalog/catalog-server.h: http://gerrit.cloudera.org:8080/#/c/23194/4/be/src/catalog/catalog-server.h@229 PS4, Line 229: If operation needs to obtain both catalog_lock_ and this, this lock must be > We don't do this in all places yet, e.g. UpdateCatalogTopicCallback. But it Updated the comment. http://gerrit.cloudera.org:8080/#/c/23194/4/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/23194/4/be/src/catalog/catalog-server.cc@801 PS4, Line 801: int64_t min_catalog_version = CATALOG_VERSION_INCREMENT_ON_RESET; > You're right. In that case. Done http://gerrit.cloudera.org:8080/#/c/23194/4/be/src/catalog/catalog-server.cc@994 PS4, Line 994: /// Only update the minimum catalog version to accept requests if > We should log the error if status is not OK. Done http://gerrit.cloudera.org:8080/#/c/23194/4/tests/custom_cluster/test_catalogd_ha.py File tests/custom_cluster/test_catalogd_ha.py: http://gerrit.cloudera.org:8080/#/c/23194/4/tests/custom_cluster/test_catalogd_ha.py@538 PS4, Line 538: > It should pass without this since --catalogd_ha_reset_metadata_on_failover= Done -- To view, visit http://gerrit.cloudera.org:8080/23194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I370d21319335318e441ec3c3455bac4227803900 Gerrit-Change-Number: 23194 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 23 Jul 2025 02:54:53 +0000 Gerrit-HasComments: Yes
