Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 )
Change subject: IMPALA-2195: Improper handling of comments in queries ...................................................................... Patch Set 14: (8 comments) Fixed all the flake8 errors and added some new tests. http://gerrit.cloudera.org:8080/#/c/9933/13/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9933/13/shell/impala_shell.py@325 PS13, Line 325: command, args), > ./shell/impala_shell.py:325:50: E128 continuation line under-indented for v Done http://gerrit.cloudera.org:8080/#/c/9933/13/shell/impala_shell.py@1344 PS13, Line 1344: if isinstance(token, sqlparse.sql.Comment): > ./shell/impala_shell.py:1344:51: E701 multiple statements on one line (colo Done http://gerrit.cloudera.org:8080/#/c/9933/13/shell/impala_shell.py@1346 PS13, Line 1346: for comment in sqlparse.tokens.Comment: > ./shell/impala_shell.py:1346:36: E701 multiple statements on one line (colo Done http://gerrit.cloudera.org:8080/#/c/9933/13/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/9933/13/tests/shell/test_shell_interactive.py@481 PS13, Line 481: 'select * from leading_comment;') > What about a test case like: Done http://gerrit.cloudera.org:8080/#/c/9933/13/tests/shell/test_shell_interactive.py@482 PS13, Line 482: assert 'Fetched 1 row(s)' in result.stderr > What about a test case like: Done http://gerrit.cloudera.org:8080/#/c/9933/13/tests/shell/test_shell_interactive.py@494 PS13, Line 494: > Same as above except using help, not select. Done http://gerrit.cloudera.org:8080/#/c/9933/13/tests/shell/test_shell_interactive.py@610 PS13, Line 610: assert ('/*delete*/ ', 'select /*do not delete*/ 1') == \ > ./tests/shell/test_shell_interactive.py:610:10: E127 continuation line over Done http://gerrit.cloudera.org:8080/#/c/9933/13/tests/shell/test_shell_interactive.py@619 PS13, Line 619: assert ('/*delete*/\n', 'select c1 from\n' > ./tests/shell/test_shell_interactive.py:619:10: E127 continuation line over Done -- To view, visit http://gerrit.cloudera.org:8080/9933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7 Gerrit-Change-Number: 9933 Gerrit-PatchSet: 14 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Thu, 07 Jun 2018 22:22:44 +0000 Gerrit-HasComments: Yes
