Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/23204 )
Change subject: IMPALA-14234: Fix a version mismatch DCHECK hit when admissiond cluster membership recovering ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23204/2/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/23204/2/be/src/scheduling/cluster-membership-mgr.cc@297 PS2, Line 297: // The recovering membership is never exposed to clients and therefore requires no : // copying. > Can we say that, "The recovering membership is not exposed to clients unles I was more concerned about if we could try to dereference the recovering_membership_ shared_ptr after underlying snapshot has been removed? http://gerrit.cloudera.org:8080/#/c/23204/2/be/src/scheduling/cluster-membership-mgr.cc@300 PS2, Line 300: if (current_membership_ != nullptr : && current_membership_->version > new_state->version) { : new_state->version = current_membership_->version; : } > Yeah, one way could be removing the DCHECK in https://github.com/apache/imp I think we should not remove the DCHECK. The ComputeGroupScheduleStates() could be called multiple times for a queued query and it's important for the current_snapshot version to be higher than previous ones so that the schedule state is based on current cluster membership. I'm however not sure how we could get into situation where current_membership_->version could decrease? We basicaly have: recovering_membership_ copied from current_membership_ ... current_membership_ gets updated with recovering_membership_ -- To view, visit http://gerrit.cloudera.org:8080/23204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea77347bd4775abd7866817146e326c7c5042f5e Gerrit-Change-Number: 23204 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Wed, 30 Jul 2025 19:59:49 +0000 Gerrit-HasComments: Yes
