Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10643 )
Change subject: IMPALA-7144: Re-enable TestDescribeTableResults ...................................................................... Patch Set 3: (11 comments) http://gerrit.cloudera.org:8080/#/c/10643/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/10643/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1810 PS2, Line 1810: > nit: remove (same for below) Done http://gerrit.cloudera.org:8080/#/c/10643/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1810 PS2, Line 1810: > nit: remove (same for below) Done http://gerrit.cloudera.org:8080/#/c/10643/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1879 PS2, Line 1879: > what data? It should be metadata. http://gerrit.cloudera.org:8080/#/c/10643/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1890 PS2, Line 1890: "hdfs://localhost:20500/test-warehouse/alltypesagg" > is there a reason for skipping EXTENDED for alltypessmall? Nope. I'll add. http://gerrit.cloudera.org:8080/#/c/10643/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1903 PS2, Line 1903: atements force > move to before use (L1809) Done http://gerrit.cloudera.org:8080/#/c/10643/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1904 PS2, Line 1904: indepe > columns_ Done http://gerrit.cloudera.org:8080/#/c/10643/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1905 PS2, Line 1905: ctional. > location_ Done http://gerrit.cloudera.org:8080/#/c/10643/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1944 PS2, Line 1944: // > use a switch instead. Done http://gerrit.cloudera.org:8080/#/c/10643/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1946 PS2, Line 1946: > should these be case insensitive? The column names in DESCRIBE output are always in lower case. I'll trim the output. http://gerrit.cloudera.org:8080/#/c/10643/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1953 PS2, Line 1953: > does this case matter? We want to match the same exact thing. So it's better to match the output in DESCRIBE. http://gerrit.cloudera.org:8080/#/c/10643/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1956 PS2, Line 1956: eak; > not obvious what is r doing... it looks like a row idx but gets bumped per I'll rename r to rowIdx and add more comments. -- To view, visit http://gerrit.cloudera.org:8080/10643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aeaecf5b6d906a66d338e165a6d506e3964563f Gerrit-Change-Number: 10643 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 08 Jun 2018 01:57:22 +0000 Gerrit-HasComments: Yes
