Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21175 )
Change subject: IMPALA-12829: Skip processing transaction events if the table is HMS sync disabled. ...................................................................... Patch Set 25: (1 comment) http://gerrit.cloudera.org:8080/#/c/21175/23/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21175/23/tests/custom_cluster/test_events_custom_configs.py@1696 PS23, Line 1696: class TestEventProcessingWithImpala(TestEventProcessingCustomConfigsBase): > In case of transactional tables, insert events are not generated, instead C I see. However, changing the intervals loses the test coverage for IMPALA-12543. It's intended to test such a scenario that HMS events triggered by the Impala DDL arrive earlier than the Impala DDL does the reload. If we can't detect such self-triggered COMMIT_TXN events, we should disable the part of inserting transactional tables, and file a follow-up JIRA to fix it (if possible). -- To view, visit http://gerrit.cloudera.org:8080/21175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d0ecb3b756755bc04c66a538a9ae6b88011a019 Gerrit-Change-Number: 21175 Gerrit-PatchSet: 25 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Aug 2025 13:01:13 +0000 Gerrit-HasComments: Yes
