Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23181 )
Change subject: IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure ...................................................................... IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure The existing code incorrectly attempts to drop the corresponding Kudu table when the creation of a Kudu external table in HMS fails due to an erroneous negation in the if condition (fortunately, there are additional checks with Preconditions in KuduCatalogOpExecutor.dropTable, causing such attempts to always fail). Additionally, when creating a Kudu synchronized table, if the table creation fails in HMS, it will unexpectedly skip deleting the corresponding Kudu table, resulting in an "already exists in Kudu" error when retrying the table creation. Removed the incorrect negation in the if condition to align with the intended behavior described in the comment. Testing: - Existing tests cover this change. Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b Reviewed-on: http://gerrit.cloudera.org:8080/23181 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b Gerrit-Change-Number: 23181 Gerrit-PatchSet: 6 Gerrit-Owner: Zihao Ye <eyiz...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com>
