Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23251 )
Change subject: IMPALA-14261: Take 'impala.computeStatsSnapshotId' into account when deciding between Puffin and HMS stats ...................................................................... Patch Set 4: Code-Review+1 (1 comment) LGTM! http://gerrit.cloudera.org:8080/#/c/23251/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/23251/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@903 PS4, Line 903: nit: line continuations need +4 spaces. But you could just return here, no need to introduce 'computeStatsMap'. -- To view, visit http://gerrit.cloudera.org:8080/23251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95a5b152dd504e94dea368a107d412e33f67930c Gerrit-Change-Number: 23251 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 12 Aug 2025 13:38:09 +0000 Gerrit-HasComments: Yes
