Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10647 )
Change subject: IMPALA-7149: Skip q7 in test_mem_usage_scaling in erasure coding build ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10647/2/tests/query_test/test_mem_usage_scaling.py File tests/query_test/test_mem_usage_scaling.py: http://gerrit.cloudera.org:8080/#/c/10647/2/tests/query_test/test_mem_usage_scaling.py@35 PS2, Line 35: @SkipIfNotHdfsMinicluster.tuned_for_minicluster What is the purpose of running this test for EC? What test coverage is this providing? Do we expect the memory consumption to be exactly the same for EC as for HDFS, given that it's still fairly timing-dependent. The background is that this test was tuned for the 3-node minicluster and tested for a while in that configuration to make sure it isn't flaky. I've tagged tests like that with the above decorator so that we don't run them in alternative configurations, and I'm not sure that carrying these tests over to EC is the right thing. -- To view, visit http://gerrit.cloudera.org:8080/10647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9a34a91eef40e1da9c7134cfb7054006d9115de Gerrit-Change-Number: 10647 Gerrit-PatchSet: 2 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 08 Jun 2018 15:58:16 +0000 Gerrit-HasComments: Yes
