Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23190 )
Change subject: IMPALA-14237: Fix Iceberg partition values encoding ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/23190/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23190/7//COMMIT_MSG@14 PS7, Line 14: Also, for an Iceberg table UrlEncode is called in not the : Hive-compatible way, rather than the standard way, similar to Java's : URLEncoder.encode() (which the Ice > Is this an actual functional bug, or just a conforming with a convention? M It just conforming with convention used by other engines, added to commit message. http://gerrit.cloudera.org:8080/#/c/23190/7/be/src/exprs/iceberg-functions-ir.cc File be/src/exprs/iceberg-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/23190/7/be/src/exprs/iceberg-functions-ir.cc@105 PS7, Line 105: if (input.len <= width.val) return input; > Can you add a comment that this is always utf8 regardless of utf8_mode? Done http://gerrit.cloudera.org:8080/#/c/23190/7/be/src/util/coding-util.cc File be/src/util/coding-util.cc: http://gerrit.cloudera.org:8080/#/c/23190/7/be/src/util/coding-util.cc@43 PS7, Line 43: ; > Why did the characters change? Please add explanation to the commit message Done http://gerrit.cloudera.org:8080/#/c/23190/7/be/src/util/coding-util.cc@70 PS7, Line 70: !IsUrlSafe(ch))) > nit: we could avoid double-negation if we can make ShouldNotEscape() -> Sho ShouldEscape would be semantically incorrect because those characters won't be escaped, so I renamed it to IsUrlSafe for better readability. http://gerrit.cloudera.org:8080/#/c/23190/7/testdata/workloads/functional-query/queries/QueryTest/iceberg-partition-transform-insert.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-partition-transform-insert.test: http://gerrit.cloudera.org:8080/#/c/23190/7/testdata/workloads/functional-query/queries/QueryTest/iceberg-partition-transform-insert.test@1104 PS7, Line 1104: select * from unicode_truncate; > Please add SELECT statements with WHERE clause to test partition pruning wo Added, also in unicode-column-name.test -- To view, visit http://gerrit.cloudera.org:8080/23190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabb39727f6dd49b76c918bcd6b3ec62532555755 Gerrit-Change-Number: 23190 Gerrit-PatchSet: 8 Gerrit-Owner: Daniel Vanko <dva...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Vanko <dva...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 18 Aug 2025 11:00:19 +0000 Gerrit-HasComments: Yes
