Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23294 )
Change subject: IMPALA-13237: [Patch 7] - Lock ClientRequestState during Opentelemetry Traces ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/23294/6/be/src/observe/span-manager.cc File be/src/observe/span-manager.cc: http://gerrit.cloudera.org:8080/#/c/23294/6/be/src/observe/span-manager.cc@419 PS6, Line 419: lock_guard<mutex> crs_lock(*(client_request_state_->lock())); Is it possible to move this RAII to the caller method of ChildSpanBuilder()? That way, we are ensuring that all of the inline methods should hold the locks they needed. It will also reduce the potential bug of obtaining the same lock twice in the future. -- To view, visit http://gerrit.cloudera.org:8080/23294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I649bdb6f88176995d45f7d10db898188bbe0b609 Gerrit-Change-Number: 23294 Gerrit-PatchSet: 6 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Pranav Lodha <pranav.lo...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 18 Aug 2025 19:07:58 +0000 Gerrit-HasComments: Yes
