Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23313 )

Change subject: IMPALA-14102: PREPENDUM - Fixed the JoinTranspose rule.
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23313/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinProjectTransposeRule.java
File 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinProjectTransposeRule.java:

http://gerrit.cloudera.org:8080/#/c/23313/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinProjectTransposeRule.java@72
PS1, Line 72:   protected static final Logger LOG = 
LoggerFactory.getLogger(ImpalaJoinProjectTransposeRule.class.getName());
line too long (110 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/23313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f62ec030fc8fbe36e6150bf96c9673c44b7da1b
Gerrit-Change-Number: 23313
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 19 Aug 2025 20:45:10 +0000
Gerrit-HasComments: Yes

Reply via email to