Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23315 )
Change subject: IMPALA-14102: Calcite Planner: Customize LoptOptimizeJoinRule ...................................................................... Patch Set 1: (7 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23315/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java: http://gerrit.cloudera.org:8080/#/c/23315/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2012 PS1, Line 2012: boolean leftSideIsGreater = (leftRowCount * leftRowSize >= rightRowCount * rightRowSize); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/23315/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2013 PS1, Line 2013: RelNode greaterSideNode = leftSideIsGreater ? left.getJoinTree() : right.getJoinTree(); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/23315/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2014 PS1, Line 2014: RelNode lesserSideNode = leftSideIsGreater ? right.getJoinTree() : left.getJoinTree(); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23315/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2015 PS1, Line 2015: boolean runtimeFilterCouldHelp = couldRuntimeFilterHelp(mq, lesserSideNode, greaterSideNode); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/23315/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2016 PS1, Line 2016: // Swap will be true if the left side is greater, but the runtime filter will help the line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23315/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2017 PS1, Line 2017: // right side. Also, swap will be true if right side is greater, but the runtime filter line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/23315/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaLoptOptimizeJoinRule.java@2030 PS1, Line 2030: private static boolean couldRuntimeFilterHelp(RelMetadataQuery mq, RelNode lesserSideNode, line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95bba7bafcc7dd86f17921c11740ac349daac6c7 Gerrit-Change-Number: 23315 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 19 Aug 2025 20:47:53 +0000 Gerrit-HasComments: Yes
