Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23312 )
Change subject: IMPALA-14102: Calcite Planner: Pre-commit... ...................................................................... Patch Set 1: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23312/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/LoptOptimizeJoinRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/LoptOptimizeJoinRule.java: http://gerrit.cloudera.org:8080/#/c/23312/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/LoptOptimizeJoinRule.java@145 PS1, Line 145: private static void findRemovableOuterJoins(RelMetadataQuery mq, LoptMultiJoin multiJoin) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/23312/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/LoptOptimizeJoinRule.java@302 PS1, Line 302: private static void findRemovableSelfJoins(RelMetadataQuery mq, LoptMultiJoin multiJoin) { line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63daf6dacf0547a0488c1ecf0bc185b548e00d87 Gerrit-Change-Number: 23312 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 19 Aug 2025 20:41:41 +0000 Gerrit-HasComments: Yes
