Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23326 )
Change subject: IMPALA-14336: Avoid loading tables during table listing in the IcebergMetaProvider ...................................................................... Patch Set 1: (2 comments) > Patch Set 1: > > Build Successful > > https://jenkins.impala.io/job/gerrit-code-review-checks/20222/ : Initial code > review checks passed. Use gerrit-verify-dryrun-external or > gerrit-verify-dryrun to run full precommit tests. Thanks for the patch, Zoltan! Overall, it LGTM, just added two minor nits. http://gerrit.cloudera.org:8080/#/c/23326/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23326/1//COMMIT_MSG@17 PS1, Line 17: Even if they are not, it shouldn't be too : problematic to get an exception a bit later. Just curious, do we already throw an exception or is it a TODO, we can maybe create a jira if it's not handled properly and add it in a TODO? http://gerrit.cloudera.org:8080/#/c/23326/1//COMMIT_MSG@20 PS1, Line 20: This patch moves the Iceberg tables out from : iceberg_test/hadoop_catalog/ that do not conform to HadoopCatalog. Maybe also add a point that this patch also cleans the existing erroneous tests. -- To view, visit http://gerrit.cloudera.org:8080/23326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ff75a751be5ad4b5159a1294eaaa304049c454a Gerrit-Change-Number: 23326 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Thu, 21 Aug 2025 17:37:17 +0000 Gerrit-HasComments: Yes
