Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23319 )
Change subject: IMPALA-14333: [part 1] Make all pytest compatible with Python3 ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/23319/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23319/1/tests/authorization/test_ranger.py@816 PS1, Line 816: > To me, this function does not clarify or simplify the code. Instead, the c I make it as function so that it will minimize the change when it replaces _run_query_as_user() calls. I hope we don't need to backport this patch. But if we do, it should be easier this way. http://gerrit.cloudera.org:8080/#/c/23319/1/tests/authorization/test_ranger.py@892 PS1, Line 892: admin_client = self.create_impala_client(user=ADMIN) > Can both of these lines use the with self.create_impala_client() as client_ We can use with-as statement, but that will shift the spaces and cause larger changes. Closing manually is more practical in this case. http://gerrit.cloudera.org:8080/#/c/23319/1/tests/custom_cluster/test_saml2_sso.py File tests/custom_cluster/test_saml2_sso.py: http://gerrit.cloudera.org:8080/#/c/23319/1/tests/custom_cluster/test_saml2_sso.py@111 PS1, Line 111: SSO_ARGS_WITH_GROUP_FILTER = ( > Since this line is being modified, why not switch to using .format? Done http://gerrit.cloudera.org:8080/#/c/23319/1/tests/custom_cluster/test_saml2_sso.py@240 PS1, Line 240: > I'm curious why this additional return variable is needed? Leftover from my debugging. Removed. http://gerrit.cloudera.org:8080/#/c/23319/2/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/23319/2/tests/shell/test_shell_interactive.py@192 PS2, Line 192: cls.ImpalaTestMatrix.add_dimension(create_impala_shell_executable_dimension()) > Duplicate of https://gerrit.cloudera.org/c/23319/2/tests/common/impala_test Removed. -- To view, visit http://gerrit.cloudera.org:8080/23319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I401a93b6cc7bcd17f41d24e7a310e0c882a550d4 Gerrit-Change-Number: 23319 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 22 Aug 2025 00:08:28 +0000 Gerrit-HasComments: Yes
