Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/6521 )
Change subject: WIP ONLY: IMPALA-3926: fix RPATH for libstdc++.so and libgcc.so ...................................................................... Patch Set 4: (1 comment) > Patch Set 4: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/6521/4/functions.sh File functions.sh: http://gerrit.cloudera.org:8080/#/c/6521/4/functions.sh@502 PS4, Line 502: symlink_lib "$src_lib" "$file" > Yeah I remember looking at some of those binary patching tools but decided Sure. I'll do the review. -- To view, visit http://gerrit.cloudera.org:8080/6521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f8481a8dfe35273a763586e9d2da0d4008ac67 Gerrit-Change-Number: 6521 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 08 Jun 2018 23:16:37 +0000 Gerrit-HasComments: Yes
