Pranav Lodha has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23334 )

Change subject: IMPALA-14290: Make Iceberg partitioning column names case 
insensitive
......................................................................


Patch Set 2:

(2 comments)

Thanks for the patch Daniel!

http://gerrit.cloudera.org:8080/#/c/23334/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23334/2//COMMIT_MSG@9
PS2, Line 9: Previously ImpalaRuntimeException occured if partition spec was 
defined
           : by not lower case column names.
Can you briefly add some info on the reason for this exception, something 
similar to the jira description (When creating or altering partitions of 
Iceberg tables, Impala only accepts column names if they are in lower case)?


http://gerrit.cloudera.org:8080/#/c/23334/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-column-case-sensitivity-issue.test
File 
testdata/workloads/functional-query/queries/QueryTest/iceberg-column-case-sensitivity-issue.test:

http://gerrit.cloudera.org:8080/#/c/23334/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-column-case-sensitivity-issue.test@39
PS2, Line 39: ====
Maybe add the following to make it complete:
-Show partitions
-Alter table with add partitions



--
To view, visit http://gerrit.cloudera.org:8080/23334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4080a6b7468fff940435e2e780322d4ba1f0de49
Gerrit-Change-Number: 23334
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Comment-Date: Fri, 22 Aug 2025 10:29:30 +0000
Gerrit-HasComments: Yes

Reply via email to