Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23319 )
Change subject: IMPALA-14333: Run impala-py.test using Python3 ...................................................................... Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/23319/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23319/5//COMMIT_MSG@42 PS5, Line 42: Nit: extra blank line http://gerrit.cloudera.org:8080/#/c/23319/5//COMMIT_MSG@45 PS5, Line 45: Python3 pytest + Python2 impala-shell combo. Are we going to need separate builds to test impala-shell with the tests running on Python 2? Otherwise, it seems to me testing of impala-shell on Python 2 will have use cases going untested. http://gerrit.cloudera.org:8080/#/c/23319/5//COMMIT_MSG@59 PS5, Line 59: default. Why did these tests work when run on Python 2 but break when run on Python 3? http://gerrit.cloudera.org:8080/#/c/23319/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23319/1/tests/authorization/test_ranger.py@816 PS1, Line 816: > I make it as function so that it will minimize the change when it replaces Sounds good to me. http://gerrit.cloudera.org:8080/#/c/23319/1/tests/authorization/test_ranger.py@892 PS1, Line 892: admin_client = self.create_impala_client(user=ADMIN) > We can use with-as statement, but that will shift the spaces and cause larg Sounds good to me. http://gerrit.cloudera.org:8080/#/c/23319/1/tests/custom_cluster/test_saml2_sso.py File tests/custom_cluster/test_saml2_sso.py: http://gerrit.cloudera.org:8080/#/c/23319/1/tests/custom_cluster/test_saml2_sso.py@111 PS1, Line 111: SSO_ARGS_WITH_GROUP_FILTER = ( > Done Done http://gerrit.cloudera.org:8080/#/c/23319/1/tests/custom_cluster/test_saml2_sso.py@240 PS1, Line 240: msg_id=str(uuid.uuid4()), > Leftover from my debugging. Removed. Done http://gerrit.cloudera.org:8080/#/c/23319/2/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/23319/2/tests/shell/test_shell_interactive.py@192 PS2, Line 192: > Removed. Done -- To view, visit http://gerrit.cloudera.org:8080/23319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I401a93b6cc7bcd17f41d24e7a310e0c882a550d4 Gerrit-Change-Number: 23319 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 22 Aug 2025 19:45:04 +0000 Gerrit-HasComments: Yes
