Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23343 )
Change subject: IMPALA-14348: Fix TSAN issue after IMPALA-14327 ...................................................................... Patch Set 1: (2 comments) > Patch Set 1: > > (2 comments) Thanks for the patch Riza! Just need some minor clarifications. http://gerrit.cloudera.org:8080/#/c/23343/1/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/23343/1/be/src/service/impala-hs2-server.cc@645 PS1, Line 645: query_handle->returns_result_set() Can we confirm whether returns_result_set_ is immutable after setup. If it is then would just adding a const solve the issue? If not, can we add a comment mentioning that returns_result_set_ can be mutable during/after query setup? http://gerrit.cloudera.org:8080/#/c/23343/1/be/src/service/impala-hs2-server.cc@673 PS1, Line 673: RETURN_IF_ERROR(query_handle->SetResultCache(result_set, cache_num_rows)); can you confirm if it would try to grab lock_ again internally with a comment? If it does, there’s potential for deadlock with a non-recursive mutex. -- To view, visit http://gerrit.cloudera.org:8080/23343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41fc25cea5b4ef7b4b9daac54b8665fa76ceb1cd Gerrit-Change-Number: 23343 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 25 Aug 2025 09:19:58 +0000 Gerrit-HasComments: Yes
