Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23319 )
Change subject: IMPALA-14333: Run impala-py.test using Python3 ...................................................................... Patch Set 11: (1 comment) Apologies for the long commit messages. Splitting the patch would be best. However, if we want to flip-the-switch right away, I think it is best to land all the changes in single commit. Thus, there will be no in-between patches slip that require additional adjustment later on. If unrelated patch merged ahead of this and broke Python3 pytest, it will be easier for me to simply rebase and fix them in this single patch. http://gerrit.cloudera.org:8080/#/c/23319/10/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/23319/10/tests/shell/test_shell_commandline.py@1108 PS10, Line 1108: f.write("select \n") > nit: should be 2-space indentation Done -- To view, visit http://gerrit.cloudera.org:8080/23319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I401a93b6cc7bcd17f41d24e7a310e0c882a550d4 Gerrit-Change-Number: 23319 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Aug 2025 23:45:01 +0000 Gerrit-HasComments: Yes
