Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10679 )
Change subject: IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10679/1/be/src/runtime/sorter.h File be/src/runtime/sorter.h: http://gerrit.cloudera.org:8080/#/c/10679/1/be/src/runtime/sorter.h@164 PS1, Line 164: /// Wrapper around BufferPool::PageHandle that tracks additional info about the page. Can we move the internal stuff to a sorter-internal.h header instead? It's not part of the public interface so it would be nice to keep it separate. -- To view, visit http://gerrit.cloudera.org:8080/10679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaaf2b75c2f789002c42939865c018f728d29a113 Gerrit-Change-Number: 10679 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sun, 10 Jun 2018 20:04:38 +0000 Gerrit-HasComments: Yes
