Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23342 )
Change subject: POC IMPALA-13125: Fix pairwise test vector generation ...................................................................... Patch Set 6: (1 comment) We can also reduce the lines in https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/functional-query_exhaustive.csv Correct way to do it is by modifying bin/generate-test-vectors.py to skip some combinations. For example, there is no definition for 'json' in bin/generate-test-vectors.py, because functional-query_exhaustive.csv was hand-edited in IMPALA-12431. Maybe it is worth reduce compression combo for rc, seq, and json. Limit orc only to orc/def/block. On the other hand, keep text format to test with all compression combo. http://gerrit.cloudera.org:8080/#/c/23342/6/tests/query_test/test_date_queries.py File tests/query_test/test_date_queries.py: http://gerrit.cloudera.org:8080/#/c/23342/6/tests/query_test/test_date_queries.py@48 PS6, Line 48: ('text', 'hbase', 'parquet', 'json') Need to add 'avro' here. -- To view, visit http://gerrit.cloudera.org:8080/23342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I419c24659a08d8d6592fadbbd5b764ff73cbba3e Gerrit-Change-Number: 23342 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 26 Aug 2025 20:46:40 +0000 Gerrit-HasComments: Yes
