Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23346 )
Change subject: IMPALA-14330: set a valid createEventId in global INVALIDATE METADATA ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23346/2/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java File fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java: http://gerrit.cloudera.org:8080/#/c/23346/2/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java@195 PS2, Line 195: // Use suppressLogging=true to avoid excessive logs for all tables during catalogd : // startup. : tbl.setCreateEventId(createEventId, true); : return tbl; > nit: Creating an overload of setCreateEventId() that log less/differently m Good point. That's better since it keeps the logs when the table is invalidated individually. http://gerrit.cloudera.org:8080/#/c/23346/2/tests/custom_cluster/test_concurrent_ddls.py File tests/custom_cluster/test_concurrent_ddls.py: http://gerrit.cloudera.org:8080/#/c/23346/2/tests/custom_cluster/test_concurrent_ddls.py@103 PS2, Line 103: self.client = test_self.create_impala_client() > nit: I've seen single ImpylaHS2Connection behave erratically when shared ac This is a thread-local variable so each thread actually creates a dedicate client. https://docs.python.org/2/library/threading.html#threading.local When running the test, I can see there are more than 10 connections. -- To view, visit http://gerrit.cloudera.org:8080/23346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6506821dedf7701cdfa58d14cae5760ee178c4ec Gerrit-Change-Number: 23346 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 27 Aug 2025 10:27:01 +0000 Gerrit-HasComments: Yes
