Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22554 )
Change subject: IMPALA-13593: Enable event processor to consume ALTER_PARTITIONS events from metastore ...................................................................... Patch Set 23: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/22554/22/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/22554/22/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1414 PS22, Line 1414: if (!notSkipped) { : metrics_.getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).inc(); : } > reloadTableFromCatalog() returns true if the table is reloaded successfully Oops, you are right, I was somehow confused by the double negation. http://gerrit.cloudera.org:8080/#/c/22554/22/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2835 PS22, Line 2835: partitionsAfter_.isEmpty() > I'll modify the log from INFO to WARNING. ack http://gerrit.cloudera.org:8080/#/c/22554/22/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2856 PS22, Line 2856: return new SelfEventContext(dbName_, tblName_, : Arrays.asList(getTPartitionSpecFromHmsPartition(msTbl_, : partitionsAfter_.get(0))), partitionsAfter_.get(0).getParameters()); > HMS will not merge events from HIVE and IMPALA into one ALTER_PARTITIONS ev ack -- To view, visit http://gerrit.cloudera.org:8080/22554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I009a87ef5e2c331272f9e2d7a6342cc860e64737 Gerrit-Change-Number: 22554 Gerrit-PatchSet: 23 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 27 Aug 2025 12:53:34 +0000 Gerrit-HasComments: Yes
