Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23279 )
Change subject: IMPALA-13237: [Patch 8] - OpenTelemetry Traces for DML/DDL Queries and Handle Leading Comments ...................................................................... Patch Set 18: (3 comments) http://gerrit.cloudera.org:8080/#/c/23279/16//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23279/16//COMMIT_MSG@6 PS16, Line 6: : IMPALA-13237: [Patch 8] - OpenTelemetry Traces for DML/DDL Queries and Handle Leading Comments : : Trace DML/DDL Queries : * Adds tracing for alter, compute, create, delete, d > Please fill in the commit message. Done http://gerrit.cloudera.org:8080/#/c/23279/16/be/src/observe/otel-test.cc File be/src/observe/otel-test.cc: http://gerrit.cloudera.org:8080/#/c/23279/16/be/src/observe/otel-test.cc@59 PS16, Line 59: runtest("--comment1\n--comment2\nselect 1"); > done Done http://gerrit.cloudera.org:8080/#/c/23279/18/be/src/observe/otel-test.cc File be/src/observe/otel-test.cc: http://gerrit.cloudera.org:8080/#/c/23279/18/be/src/observe/otel-test.cc@43 PS18, Line 43: runtest("SELECT * FROM foo"); Please add test where there is a new line right after keywork. i.e., Will this work? SELECT tiny_int FROM functional.alltypes; -- To view, visit http://gerrit.cloudera.org:8080/23279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9e83d7f761f3d629f067e0a0602224e42cd7184 Gerrit-Change-Number: 23279 Gerrit-PatchSet: 18 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 28 Aug 2025 19:25:05 +0000 Gerrit-HasComments: Yes
