Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 )
Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10669/1/be/src/runtime/fragment-instance-state.cc File be/src/runtime/fragment-instance-state.cc: http://gerrit.cloudera.org:8080/#/c/10669/1/be/src/runtime/fragment-instance-state.cc@a371 PS1, Line 371: : : > An alternative we discussed is to bump this log statement to VLOG_ROW() or >From git blame, it appears to be added in 368115cda. Probably was useful when >developing that change. Let's not worry about deleting it if we find it a >nuisance now. -- To view, visit http://gerrit.cloudera.org:8080/10669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0445950385fa6160764feaed9a993fa0e59b242 Gerrit-Change-Number: 10669 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Jun 2018 16:35:33 +0000 Gerrit-HasComments: Yes
