Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23279 )
Change subject: IMPALA-13237: [Patch 8] - OpenTelemetry Traces for DML/DDL Queries and Handle Leading Comments ...................................................................... Patch Set 26: (2 comments) http://gerrit.cloudera.org:8080/#/c/23279/25/be/src/observe/span-manager.cc File be/src/observe/span-manager.cc: http://gerrit.cloudera.org:8080/#/c/23279/25/be/src/observe/span-manager.cc@300 PS25, Line 300: const string* profile_adm_res = client_request_state_->summary_profile()-> : GetInfoString("Admission result"); > There might be more overlooked places where nullptr is possible like this, Ack http://gerrit.cloudera.org:8080/#/c/23279/25/tests/custom_cluster/test_otel_trace.py File tests/custom_cluster/test_otel_trace.py: http://gerrit.cloudera.org:8080/#/c/23279/25/tests/custom_cluster/test_otel_trace.py@789 PS25, Line 789: : : class TestOtelTraceSelectQueued(TestOtelTrace): : """Tests that require setting additional startup flags to assert admission control : queueing behavior. The cluster must be restarted after each test to apply the : new flags.""" : : @CustomClusterTestSuite.with_args( : impalad_args="-v=2 --cluster_id=select_queued --default_pool_max_requests=1 {}" : .format(TRACE_FLAGS), : cluster_size=1, tmp_dir_placeholders=[OUT_DIR], disable_log_buffering=True) : def test_select_queued(self): : # Launch two queries, the second will be queued until the first completes. : query = "SELECT * FROM functional.alltypes WHERE id = 1" : handle1 = self.client.execute_async("{} AND int_col = SLEEP(5000)".format(query)) : self.client.wait_for_impala_state(handle1, RUNNING, 60) : query_id_1 = self.client.handle_id(handle1) : : handle2 = self.client.execute_async(query) : query_id_2 = self.client.handle_id(handle2) : : self.client.wait_for_impala_state(handle1, FINISHED, 60) : self.client.fetch(None, handle1) : query_profile_1 = self.client.get_runtime_profile(handle1) : self.client.close_query(handle1) : : self.client.wait_for_impala_state(handle2, FINISHED, 60) : self.client.fetch(None, handle2) : query_profile_2 = self.client.get_runtime_profile(handle2) : : self.client.close_query(handle2) : : self.assert_trace( : query_id=query_id_1, : query_profile=query_profile_1, : cluster_id="select_queued", : trace_cnt=3) : : self.assert_trace( : query_id=query_id_2, : query_profile=query_profile_2, : cluster_id="select_queued", : trace_cnt=3) > nit: This is already represented by otel-test.cc and can be removed. Done -- To view, visit http://gerrit.cloudera.org:8080/23279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9e83d7f761f3d629f067e0a0602224e42cd7184 Gerrit-Change-Number: 23279 Gerrit-PatchSet: 26 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Sat, 30 Aug 2025 02:25:03 +0000 Gerrit-HasComments: Yes
