Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23380 )
Change subject: IMPALA-13806: Avoid per-function std::locale creation ...................................................................... Patch Set 1: (1 comment) Thanks for working on this! It'd be nice to see how much the performance is improved. http://gerrit.cloudera.org:8080/#/c/23380/1/be/src/exprs/mask-functions-ir.cc File be/src/exprs/mask-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/23380/1/be/src/exprs/mask-functions-ir.cc@149 PS1, Line 149: & Could you explain why we use reference (&) here? Is it still valid after the lambda function returns? -- To view, visit http://gerrit.cloudera.org:8080/23380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a611ba1b175b0ab1c8f0d1de3b2439be70a68f7 Gerrit-Change-Number: 23380 Gerrit-PatchSet: 1 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 04 Sep 2025 12:20:48 +0000 Gerrit-HasComments: Yes
