Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/23159 )
Change subject: IMPALA-14082: Support batch processing of RELOAD events on same table ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/23159/6/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/23159/6/tests/custom_cluster/test_events_custom_configs.py@578 PS6, Line 578: " --enable_skipping_older_events=true") Because reload events don't rely on selfevent() (instead they rely on isOlderEvent()) we need this flag so that L#621 passes. http://gerrit.cloudera.org:8080/#/c/23159/6/tests/custom_cluster/test_events_custom_configs.py@647 PS6, Line 647: assert part_events_skipped_after == part_events_skipped_before Previously reload partition is processed one by one, so when batch events are generated, the first event reloads the partition and set's last refresh event id as the latest event Id from HMS and the subsequent events are skipped. In the current patch, since we batch all 10 events together, they reload at once, hence there are events being skipped (which is the right behaviour). -- To view, visit http://gerrit.cloudera.org:8080/23159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3e9a99b666a1c928ac2a136bded1e5420f77dab Gerrit-Change-Number: 23159 Gerrit-PatchSet: 6 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 04 Sep 2025 23:04:59 +0000 Gerrit-HasComments: Yes
