Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22914 )
Change subject: IMPALA-14081: Support create/drop paimon table for impala ...................................................................... Patch Set 17: Code-Review+1 (1 comment) Nice work, LGTM! http://gerrit.cloudera.org:8080/#/c/22914/17/fe/src/main/java/org/apache/impala/catalog/paimon/PaimonTable.java File fe/src/main/java/org/apache/impala/catalog/paimon/PaimonTable.java: http://gerrit.cloudera.org:8080/#/c/22914/17/fe/src/main/java/org/apache/impala/catalog/paimon/PaimonTable.java@210 PS17, Line 210: PARTITION_VALUE_SERIALIZED Since it's Paimon-specific I think we should call it PAIMON_PARTITION_VALUE_SERIALIZED. -- To view, visit http://gerrit.cloudera.org:8080/22914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57e77f28151e4a91353ef77050f9f0cd7d9d05ef Gerrit-Change-Number: 22914 Gerrit-PatchSet: 17 Gerrit-Owner: ji chen <jichen0...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Pranav Lodha <pranav.lo...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: ji chen <jichen0...@163.com> Gerrit-Comment-Date: Fri, 05 Sep 2025 15:56:52 +0000 Gerrit-HasComments: Yes
