Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 )
Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog ...................................................................... Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@49 PS2, Line 49: : new MetaStor > nit: single line Done http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java File fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java: http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java@53 PS2, Line 53: which does not interact with catalogd > Although it could, if a hypothetical CatalogdMetaProvider is implemented (a good point. I'll rephrase this to say that this implements a "pull-based" catalog design -- the source might be the direct metadata sources, or an intermediate node like catalogd. http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java@72 PS2, Line 72: metaProvider > precondition to assert non-null. Done http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java@76 PS2, Line 76: matcher > where's this used? woops, good catch! copy paste fail. Fixed and added tests. http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java@88 PS2, Line 88: list > nit: names (seems more intuitive) Done http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java File fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java: http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java@44 PS2, Line 44: name_ > lowercase? added docs http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java@53 PS2, Line 53: catalog, String dbName > precondition for non-null Done http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java@71 PS2, Line 71: e); > nit: pull up to prev. line Done http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java@85 PS2, Line 85: assert tb > use precondition, and check non-null. Done http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java@122 PS2, Line 122: c > nit: C Done http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java: http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@42 PS2, Line 42: name_ > lowercase? Done http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java: http://gerrit.cloudera.org:8080/#/c/10627/2/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java@33 PS2, Line 33: * or may include caching, etc. > so far, this covers a portion of hms. pls add a todo for covering other hms Done -- To view, visit http://gerrit.cloudera.org:8080/10627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab653371188b21c72f50ee1ec4e94950aa6fb9ee Gerrit-Change-Number: 10627 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Jun 2018 00:14:17 +0000 Gerrit-HasComments: Yes
