Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23382 )

Change subject: IMPALA-14400: Fix deadlock in 
CatalogServiceCatalog.getDbProperty()
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23382/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

http://gerrit.cloudera.org:8080/#/c/23382/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@504
PS4, Line 504:       versionLock_.writeLock().lock();
             :       try {
             :         if (!resetManager_.isActive()) {
A more sensible approach might be to not require acquire write lock here to 
accessing isActive().
If isActive() is true, sleep for some ms and loop again.



--
To view, visit http://gerrit.cloudera.org:8080/23382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3162472ea9531add77886bf1d0d73460ff34d07a
Gerrit-Change-Number: 23382
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Sep 2025 14:47:36 +0000
Gerrit-HasComments: Yes

Reply via email to