Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10680 )
Change subject: IMPALA-3816, IMPALA-4065: Remove the indirection to TupleRowComparator::Compare() ...................................................................... IMPALA-3816, IMPALA-4065: Remove the indirection to TupleRowComparator::Compare() This patch removes the indirection of codegened TupleRowComparator:: Compare() at its call sites in sorter and topn node. It's implemented by cloning and modifying all the functions between the codegened entry function and Compare(). The call site in SortedRunMerger is still indirect. Change-Id: If4657ac09daf20408797856d94521d417d8cf171 --- M be/src/codegen/gen_ir_descriptions.py M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/exchange-node.cc M be/src/exec/topn-node.cc M be/src/runtime/data-stream-test.cc M be/src/runtime/sorted-run-merger.cc M be/src/runtime/sorter-internal.h M be/src/runtime/sorter.cc M be/src/util/tuple-row-compare.cc M be/src/util/tuple-row-compare.h A tests/custom_cluster/test_replace_tuple_row_compare.py 12 files changed, 414 insertions(+), 224 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/10680/2 -- To view, visit http://gerrit.cloudera.org:8080/10680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If4657ac09daf20408797856d94521d417d8cf171 Gerrit-Change-Number: 10680 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
