Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23113 )
Change subject: IMPALA-13267: Display number of partitions for Iceberg tables ...................................................................... Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/23113/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23113/7//COMMIT_MSG@22 PS7, Line 22: > Nit: no need for "the". Done http://gerrit.cloudera.org:8080/#/c/23113/7//COMMIT_MSG@24 PS7, Line 24: ns]/ > Nit: maybe NA or "?" would be better since we already have a "/". You are right, it didn't look good. Changed it to 'unknown'. http://gerrit.cloudera.org:8080/#/c/23113/7/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java: http://gerrit.cloudera.org:8080/#/c/23113/7/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@409 PS7, Line 409: public static List<TIcebergPartition> convertPartitionMapToList( > Now that we have getPartitionList(), this function and convertPartitionList This is used for the FileMetadataLoaderTest, but changed the other (convertPartitionListToMap()) to private. http://gerrit.cloudera.org:8080/#/c/23113/7/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/23113/7/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@74 PS7, Line 74: > Unused import. Done http://gerrit.cloudera.org:8080/#/c/23113/7/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/23113/7/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@2086 PS7, Line 2086: getNumPartitions(table)); > This could be getNumPartitions(), in case it changes in the future. Done -- To view, visit http://gerrit.cloudera.org:8080/23113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb2f654bc6c9bdf9cfafc27b38b5ca2f7b6b4872 Gerrit-Change-Number: 23113 Gerrit-PatchSet: 10 Gerrit-Owner: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 09 Sep 2025 10:33:14 +0000 Gerrit-HasComments: Yes
