Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23385 )
Change subject: IMPALA-14401: Deflake/Improve OpenTelemetry Tracing Tests ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/23385/12/tests/util/otel_trace.py File tests/util/otel_trace.py: http://gerrit.cloudera.org:8080/#/c/23385/12/tests/util/otel_trace.py@20 PS12, Line 20: import logging All changes in the file were copied from test_otel_trace.py with limited modifications to remove imports that were not used in the copied code and to remove the dependency on 'self.assert_impalad_log_contains()'. http://gerrit.cloudera.org:8080/#/c/23385/12/tests/util/otel_trace.py@361 PS12, Line 361: def assert_trace(log_file_path, trace_file_path, trace_file_count, query_id, The first three parameters 'log_file_path', 'trace_file_path', and 'trace_file_count' are new. Previously, this function retrieved those values by calling 'self.build_log_path()', 'self.trace_file_path', and 'self.trace_file_count'. All usage of 'log_file_path' is new. This data is needed to remove the call to 'self.assert_impalad_log_contains()' in the '__find_span_log()' function. http://gerrit.cloudera.org:8080/#/c/23385/12/tests/util/otel_trace.py@580 PS12, Line 580: def __find_span_log(log_file_path, span_name, query_id): This function has been modified to remove its dependency on 'self.assert_impalad_log_contains()'. -- To view, visit http://gerrit.cloudera.org:8080/23385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c3e0075df688c7ae601c6f2e5743f56d6db100e Gerrit-Change-Number: 23385 Gerrit-PatchSet: 12 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 12 Sep 2025 17:00:48 +0000 Gerrit-HasComments: Yes
