Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23362 )
Change subject: WIP: combo local branch patch ...................................................................... Patch Set 21: (11 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23362/21/fe/src/main/java/org/apache/impala/analysis/InPredicate.java File fe/src/main/java/org/apache/impala/analysis/InPredicate.java: http://gerrit.cloudera.org:8080/#/c/23362/21/fe/src/main/java/org/apache/impala/analysis/InPredicate.java@166 PS21, Line 166: protected Function getFunction(Analyzer analyzer, boolean isAllConstant) line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@657 PS21, Line 657: // if both precisions are not -1, they are both varchars line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java: http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@241 PS21, Line 241: RelDataType retType = ImpalaTypeConverter.createRelDataType(factory, impalaReturnType); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java: http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java@40 PS21, Line 40: protected static final Logger LOG = LoggerFactory.getLogger(AnalyzedInPredicate.class.getName()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java: http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java@46 PS21, Line 46: * Impala provides, not the default type. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java: http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java@365 PS21, Line 365: Function fn = FunctionResolver.getExactFunction(aggFunction.getName(), aggFunction.getKind(), line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java: http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@228 PS21, Line 228: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaIntersectToDistinctRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaIntersectToDistinctRule.java: http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaIntersectToDistinctRule.java@44 PS21, Line 44: * line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java: http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java@184 PS21, Line 184: RelOptCluster newCluster = RelOptCluster.create(new VolcanoPlanner(), rexBuilder); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java: http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@108 PS21, Line 108: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java File java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java: http://gerrit.cloudera.org:8080/#/c/23362/21/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java@81 PS21, Line 81: protected static final Logger LOG = LoggerFactory.getLogger(TestReduceExprShuttle.class.getName()); line too long (101 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30332e0187118af5e8feb646af42955369fa8f75 Gerrit-Change-Number: 23362 Gerrit-PatchSet: 21 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 12 Sep 2025 19:48:53 +0000 Gerrit-HasComments: Yes
